But any decent code review process would’ve exposed this, or at least a data surveillance system that checks this stuff. I’ve received a few notifications about my logs storing inappropriate data, as a result of a scanning system.
Some manager knew about this during a code review, and signed off on the risk because it was only in-house.
“mistake”
I call BS. The reviews I’ve gone through for trivial stuff would’ve exposed this.
This was intentional.
Hanlon’s Razor revised: Never attribute to malice what can be attributed to incompetence, except where there is an established pattern of malice.
Then incompetence at a level that’s incomprehensible.
A code review certainly exposed this, and some manager signed off on the risk.
Again, changes I make are trivial in comparison, and our code/risk reviews would’ve exposed this in no time.
Yeah, cause trivial systems are a lot easier to parse and review. At a base level that’s nonsense logic.
My point being the extensiveness of a review process.
The more important a system, the more people it impacts, etc, the more extensive the review process.
Someone chose to ignore this risk. That’s intentional.
You quite frankly, don’t know what happened and if you’re confident it’s intentional, all that says is that you’re a grump who likes to complain.
Never assume malice when something can be explained by stupidity
I generally agree.
But any decent code review process would’ve exposed this, or at least a data surveillance system that checks this stuff. I’ve received a few notifications about my logs storing inappropriate data, as a result of a scanning system.
Some manager knew about this during a code review, and signed off on the risk because it was only in-house.
A mistake doesn’t mean it’s an accident. A mistake means they made the wrong choice.